Replace invalid test value B&W with B!W since & is valid now with nesting#39
Open
jacobcassidy wants to merge 1 commit intomicrosoft:mainfrom
Open
Replace invalid test value B&W with B!W since & is valid now with nesting#39jacobcassidy wants to merge 1 commit intomicrosoft:mainfrom
B&W with B!W since & is valid now with nesting#39jacobcassidy wants to merge 1 commit intomicrosoft:mainfrom
Conversation
romainmenke
approved these changes
Feb 13, 2025
Contributor
romainmenke
left a comment
romainmenke
left a comment
There was a problem hiding this comment.
Thank you for this @jacobcassidy!
LGTM!
(I don't have write access, so this approval doesn't really mean anything 😅)
Contributor
|
@aeschli Can you take a look at this when you have time? |
aeschli
approved these changes
Jun 5, 2025
Contributor
|
Thanks @romainmenke ! |
sandy081
approved these changes
Jun 5, 2025
|
Who has write access here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@romainmenke, Here's a small update to the test values to fix it marking the nesting selector
&as invalid when appended to a class, such as.main-class { .appended-class& {} }(Ref: CSS Nested Declarations)